OMNeT++/OMNEST Bug Tracker - OMNeT++ |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000946 | OMNeT++ | simulation kernel | public | 2016-02-19 13:31 | 2017-02-01 16:42 |
|
| Reporter | till | |
| Assigned To | rhornig | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 5.0b3 | |
| Target Version | | Fixed in Version | 5.1pre3 | |
|
| Summary | 0000946: Namespace missing in __REGISTER_CONFIGOPTION(ID, ARGLIST) in regmacros.h |
| Description | #define __REGISTER_CONFIGOPTION(ID, ARGLIST) \
cConfigOption *ID; \
EXECUTE_ON_STARTUP(omnetpp::configOptions.getInstance()->add(ID = new omnetpp::cConfigOption ARGLIST);)
should be
#define __REGISTER_CONFIGOPTION(ID, ARGLIST) \
omnetpp::cConfigOption *ID; \
EXECUTE_ON_STARTUP(omnetpp::configOptions.getInstance()->add(ID = new omnetpp::cConfigOption ARGLIST);) |
| Steps To Reproduce | |
| Additional Information | Patch attached! There are probably more places where the new omnetpp namespace is missing!
Can I vote again for an omnetpp git repository? It must not be up to date (would be sufficient to push only the betas there!) Would be much easier to branch and patch there and propose a pull request |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  regmacros.h.patch (364) 2016-02-19 13:31
https://dev.omnetpp.org/bugs/file_download.php?file_id=192&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-02-19 13:31 | till | New Issue | |
| 2016-02-19 13:31 | till | File Added: regmacros.h.patch | |
| 2016-02-22 12:56 | rhornig | Note Added: 0001164 | |
| 2016-02-22 12:56 | rhornig | Status | new => resolved |
| 2016-02-22 12:56 | rhornig | Fixed in Version | => 5.0 |
| 2016-02-22 12:56 | rhornig | Resolution | open => fixed |
| 2016-02-22 12:56 | rhornig | Assigned To | => rhornig |
| 2016-02-24 15:41 | till | Note Added: 0001165 | |
| 2016-02-24 15:41 | till | Status | resolved => feedback |
| 2016-02-24 15:41 | till | Resolution | fixed => reopened |
| 2016-03-04 10:08 | rhornig | Note Added: 0001167 | |
| 2016-03-04 10:08 | rhornig | Status | feedback => resolved |
| 2016-03-04 10:08 | rhornig | Resolution | reopened => fixed |
| 2016-03-04 12:02 | rhornig | Note Deleted: 0001167 | |
| 2016-03-04 12:05 | rhornig | Note Added: 0001176 | |
| 2016-03-04 12:05 | rhornig | Note Edited: 0001176 | bug_revision_view_page.php?bugnote_id=1176#r12 |
| 2016-03-04 13:09 | till | Note Added: 0001177 | |
| 2016-03-04 13:09 | till | Status | resolved => feedback |
| 2016-03-04 13:09 | till | Resolution | fixed => reopened |
| 2017-02-01 16:42 | andras | Note Added: 0001301 | |
| 2017-02-01 16:42 | andras | Status | feedback => resolved |
| 2017-02-01 16:42 | andras | Fixed in Version | 5.0 => 5.1pre3 |
| 2017-02-01 16:42 | andras | Resolution | reopened => fixed |
|
Notes |
|
|
|
|
|
|
(0001165)
|
|
till
|
|
2016-02-24 15:41
|
|
|
Sorry for bringing that up again! Could you also add a "static" in front of that line? |
|
|
|
|
Putting static there results in build errors. Why do you need it to be local to the compilation unit?
|
|
|
|
(0001177)
|
|
till
|
|
2016-03-04 13:09
|
|
Sorry, I had to reopen to answer:
clang gives a warning:
no previous extern declaration for non-static variable 'CFGID_EVENTLOG_TLOG_FILE' [-Wmissing-variable-declarations]
If you need that to be not static (I understand that, I had not thought about config options being shared by several modules) we can keep it like that and I have to add extern omnetpp::cConfigOption * in my header files (what is fine I think). The cleaner solution would probably be to not share the Options by using externs, but by retrieving them using their ID for example. I guess that is a change that requires a bit too much effort right now? |
|
|
|
(0001301)
|
|
andras
|
|
2017-02-01 16:42
|
|
|
Original issue "Namespace missing" has been fixed, please open another ticket(s) if there are additional issues. |
|