0001040: Queue and PassiveQueue modules of "queueinglib" wrong statistics collection

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001040

OMNeT++

examples

public

2018-05-30 12:29

Reporter

vallejo

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

x86

Windows

OS Version

Vista

Product Version

5.3

Target Version

Fixed in Version

Summary

0001040: Queue and PassiveQueue modules of "queueinglib" wrong statistics collection

Description

Queue and PassiveQueue modules incorrectly collect statistics for 0 messages situation.

In Queue::handleMessage, the empty queue situation is handled with the following code:

....
if (queue.isEmpty()) {
    jobServiced = nullptr;
    emit(busySignal, false);
}
....

With this code, the statistics for 0 messages situation are not correctly collected, affecting also the histogram.

A possible solution is to emit the proper signal:

....
if (queue.isEmpty()) {
    jobServiced = nullptr;
    emit(busySignal, false);
    emit(queueLengthSignal, 0); /* Proposed solution */
}
....

The same problem occurs in PassiveQueue:

....
else if (length() == 0) {
    // send through without queueing
    sendJob(job, k);
}
....

could be changed to:

....
else if (length() == 0) {
    // send through without queueing
    emit(queueLengthSignal, 0); /* Proposed solution */
    sendJob(job, k);
}
....

Issue History
Date Modified	Username	Field	Change
2018-05-30 12:29	vallejo	New Issue

Relationships

Notes
There are no notes attached to this issue.