| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000091 | OMNeT++ | simulation kernel | public | 2009-07-31 17:32 | 2009-08-03 12:07 |
|
| Reporter | kosi | |
| Assigned To | andras | |
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 4.0 | |
| Target Version | | Fixed in Version | 4.1 | |
|
| Summary | 0000091: cArray::clear() does not check for NULL |
| Description | In cArray, when you remove an object, the coresponding element of the array is set to NULL, but the clear method seems to assume that elements were only deleted from the end of the array. So if you create an array of at least two elements and delete an element other than the last you get a segfault:
cArray arr;
arr.add(new Message());
arr.add(new Message());
arr.remove(0);
arr.clear(); //segfault here
I've attached a fix for this problem which doesn't change the semantics of the
add/remove operators. Another possible fix is to have the remove method swap the current object with the last object, though probably some code would break. |
| Tags | No tags attached. |
|
| Attached Files |  carray.diff [^] (327 bytes) 2009-07-31 17:32 [Show Content] [Hide Content]--- carray_old.cc 2009-07-31 18:24:52.182002495 +0200
+++ carray.cc 2009-07-31 18:25:44.711611148 +0200
@@ -217,6 +217,8 @@
for (int i=0; i<=last; i++)
{
cObject *obj = vect[i];
+ if (!obj)
+ continue;
if (!obj->isOwnedObject())
delete obj;
else if (obj->getOwner()==this)
|
|
Relationships 
Relationships 