0000982: ${resultdir} variable gone or inaccessible?

(0001282)
rhornig (administrator)
2017-02-01 14:21

It should be still available. How do you read the configuration option in the custom vector manager?

(0001288)
till (reporter)
2017-02-01 14:46
edited on: 2017-02-01 17:41

I register the option like this:
Register_PerRunConfigOption(CFGID_CHECKOUTPUTVECTORMANAGER_REPORTFILE, "checkoutputvectormanager-reportfile",
CFG_FILENAME, "${resultdir}/${configname}-${runnumber}-constraintReport.csv", "TBD");

and use it like this:
reportFilename = omnetpp::getEnvir()->getConfig()->getAsFilename(CFGID_CHECKOUTPUTVECTORMANAGER_REPORTFILE);

Until 5.0 this works. Problem occurs with preview 2:

<!> Error: Could not read option checkoutputvectormanager-reportfile= from the configuration: No such variable: ${resultdir}

(0001292)
till (reporter)
2017-02-01 15:15
edited on: 2017-02-01 17:59

Hmmm, Is it a problem to read the config in the constructor of the result manager?

It looks like the variables are not initialized then. But it must have something todo with changes for 5.1!

(0001308)
andras (administrator)
2017-02-03 14:25

It's not a good idea to read the option in the constructor. It is a per-run option, but the object is is created only once (and reused for all runs). When read in the constructor, different settings for each run will not take effect.

It is better to read the option e.g. in the startRun() method.

(0001309)
till (reporter)
2017-02-03 14:51
edited on: 2017-02-03 14:51

Understood!

What would be the correct place for an EventLogManager? startRecording()?

(0001310)
andras (administrator)
2017-02-07 10:34

The built-in eventlog manager EventlogFileManager (envir/eventlogfilemgr.cc/h) does such things in configure(), called from the LF_PRE_NETWORK_SETUP lifecycle event.

(0001331)
andras (administrator)
2017-03-02 13:01

Seems like it's been clarified... (Please reopen if not)

Issue History
Date Modified	Username	Field	Change
2017-01-11 15:22	till	New Issue
2017-02-01 14:21	rhornig	Note Added: 0001282
2017-02-01 14:21	rhornig	Assigned To	=> rhornig
2017-02-01 14:21	rhornig	Status	new => feedback
2017-02-01 14:46	till	Note Added: 0001288
2017-02-01 14:46	till	Status	feedback => @50@
2017-02-01 15:15	till	Note Added: 0001292
2017-02-01 15:20	till	Note Added: 0001294
2017-02-01 17:40	till	Note Deleted: 0001294
2017-02-01 17:41	till	Note Edited: 0001288	View Revisions
2017-02-01 17:59	till	Note Edited: 0001292	View Revisions
2017-02-03 14:16	andras	Assigned To	rhornig => andras
2017-02-03 14:16	andras	Status	@50@ => feedback
2017-02-03 14:25	andras	Note Added: 0001308
2017-02-03 14:51	till	Note Added: 0001309
2017-02-03 14:51	till	Status	feedback => @50@
2017-02-03 14:51	till	Note Edited: 0001309	View Revisions
2017-02-05 10:35	rhornig	Status	@50@ => feedback
2017-02-07 10:34	andras	Note Added: 0001310
2017-03-02 13:01	andras	Note Added: 0001331
2017-03-02 13:01	andras	Status	feedback => resolved
2017-03-02 13:01	andras	Fixed in Version	=> 5.1
2017-03-02 13:01	andras	Resolution	open => no change required

Notes
(0001282) rhornig (administrator) 2017-02-01 14:21	It should be still available. How do you read the configuration option in the custom vector manager?

(0001288) till (reporter) 2017-02-01 14:46 edited on: 2017-02-01 17:41	I register the option like this: Register_PerRunConfigOption(CFGID_CHECKOUTPUTVECTORMANAGER_REPORTFILE, "checkoutputvectormanager-reportfile", CFG_FILENAME, "${resultdir}/${configname}-${runnumber}-constraintReport.csv", "TBD"); and use it like this: reportFilename = omnetpp::getEnvir()->getConfig()->getAsFilename(CFGID_CHECKOUTPUTVECTORMANAGER_REPORTFILE); Until 5.0 this works. Problem occurs with preview 2: <!> Error: Could not read option checkoutputvectormanager-reportfile= from the configuration: No such variable: ${resultdir}

(0001292) till (reporter) 2017-02-01 15:15 edited on: 2017-02-01 17:59	Hmmm, Is it a problem to read the config in the constructor of the result manager? It looks like the variables are not initialized then. But it must have something todo with changes for 5.1!

(0001308) andras (administrator) 2017-02-03 14:25	It's not a good idea to read the option in the constructor. It is a per-run option, but the object is is created only once (and reused for all runs). When read in the constructor, different settings for each run will not take effect. It is better to read the option e.g. in the startRun() method.

(0001309) till (reporter) 2017-02-03 14:51 edited on: 2017-02-03 14:51	Understood! What would be the correct place for an EventLogManager? startRecording()?

(0001310) andras (administrator) 2017-02-07 10:34	The built-in eventlog manager EventlogFileManager (envir/eventlogfilemgr.cc/h) does such things in configure(), called from the LF_PRE_NETWORK_SETUP lifecycle event.

(0001331) andras (administrator) 2017-03-02 13:01	Seems like it's been clarified... (Please reopen if not)

Relationships