0000995: Assert condition fails for ini files with CRLF line terminators in inifilereader

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000995

OMNeT++

simulation kernel

public

2017-02-09 16:42

2017-02-23 15:52

Reporter

till

Assigned To

andras

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

x86-64

macOS

OS Version

10.12

Product Version

5.1pre3

Target Version

Fixed in Version

5.1

Summary

0000995: Assert condition fails for ini files with CRLF line terminators in inifilereader

Description

For Files with CRLF line terminators the inifilereader fails since omnetpp 5.1:

<!> Error: ASSERT: Condition 'rawLine.empty() || (*(rawLine.end()-1) != '\r' && *(rawLine.end()-1) != '\n')' does not hold in function internalReadFile, inifilereader.cc line 137

Steps To Reproduce

file omnetpp.ini
     omnetpp.ini: ASCII text
unix2dos omnetpp.ini
file omnetpp.ini
     omnetpp.ini: ASCII text, with CRLF line terminators
opp_run ....
     <!> Error: ASSERT: Condition 'rawLine.empty() || (*(rawLine.end()-1) != '\r' && *(rawLine.end()-1) != '\n')' does not hold in function internalReadFile, inifilereader.cc line 137

Tags

No tags attached.

Attached Files

Relationships

Notes
(0001327) andras (administrator) 2017-02-23 15:48	Yeah, this bug was introduced when the code was converted from FILE* I/O to C++ iostreams late last year, for 5.1pre2. Old code right-trimmed the line, which was lost during the conversion. Thanks Till for reporting!

Issue History
Date Modified	Username	Field	Change
2017-02-09 16:42	till	New Issue
2017-02-23 15:48	andras	Note Added: 0001327
2017-02-23 15:48	andras	Status	new => resolved
2017-02-23 15:48	andras	Fixed in Version	=> 5.1
2017-02-23 15:48	andras	Resolution	open => fixed
2017-02-23 15:48	andras	Assigned To	=> andras